Repository navigation
Report a non-bool condition of the conditional operator as a type mismatch. - #1383
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1003153382
branch
17 times, most recently
from
October 23, 2026 15:53
08283fd to
2d0ba46
Compare
…match. The `filter`, `exists_one` and `map` with a filter macros expand their predicate into the condition of `_?_:_`. When the predicate isn't a bool the type-checker reports `found no matching overload for '_?_:_' applied to ...'`, which points at an operator that doesn't appear in the expression. Report `expected type 'bool' but found '<type>'` at the condition instead, as is already done for the operands of `&&` and `||`. PiperOrigin-RevId: 1005646592
copybara-service
Bot
force-pushed
the
test_1003153382
branch
from
October 23, 2026 16:12
2d0ba46 to
90cd1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report a non-bool condition of the conditional operator as a type mismatch.
The
filter,exists_oneandmapwith a filter macros expand their predicate into the condition of_?_:_. When the predicate isn't a bool the type-checker reportsfound no matching overload for '_?_:_' applied to ...', which points at an operator that doesn't appear in the expression.Report
expected type 'bool' but found '<type>'at the condition instead, as is already done for the operands of&&and||.