Repository navigation
Conversation
Accept darwin at the pool-creation and template-creation gates, and map it to the existing POSIX bash wrapper (there is no darwin-specific variant). List the Tart provider and document macOS pool specifics. Refs cloudbase#935 Depends on cloudbase/garm-provider-common#61 (temporary replace directive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GARM's OS vocabulary is
linux | windowsonly, so a macOS pool has to masquerade aslinuxand a macOS runner-install template has to be registered aslinux. The provider works, but every operator has to be told the wrong word.This is the second half of cloudbase/garm-provider-common#61 (tracked in #935). It lets macOS external providers (e.g. a Tart provider running ephemeral macOS VMs on Apple Silicon) declare
darwinfor real.Change
runner/types.go: acceptdarwinin the pool-creation gate (supportedOSType).params/requests.go: acceptdarwininCreateTemplateParams.Validate.cmd/garm-cli/cmd/templates.go: acceptdarwinin thetemplate createandtemplate restoreclient-side gates.internal/templates/templates.go: mapdarwinto the existing POSIX bash wrapper (there is no darwin-specific wrapper; the injected wrapper is plain POSIX bash and works unchanged on macOS).README.md+doc/providers.md: list the Tart provider.doc/macos.md: document macOS pool specifics — no cloud-init so--runner-install-templateis required, the two-guests-per-host licence cap (policy, not enforced by GARM), and the unlocked login keychain requirement since macOS 15.Status: blocked on garm-provider-common#61
go.modcurrently carries a temporaryreplaceofgithub.com/cloudbase/garm-provider-commonto a fork commit that contains theDarwinconstant. Once cloudbase/garm-provider-common#61 is merged, this PR will drop thereplaceand pin the merged pseudo-version. The vendor tree is committed because CI runsmake verify-vendor.