Skip to content

Fix username validation in rws. - #1728

Merged
veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:fix-store-validation
Oct 16, 2026
Merged

veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:fix-store-validation

Conversation

@veluca93

Copy link
Copy Markdown
Contributor

No description provided.

@veluca93
veluca93 requested review from gollux and prandla October 16, 2026 06:15
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.72%. Comparing base (1914a5a) to head (491ed4f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmsranking/Store.py 0.00% 5 Missing ⚠️
cmsranking/RankingWebServer.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   56.72%   56.72%   -0.01%     
==========================================
  Files         344      344              
  Lines       28312    28314       +2     
==========================================
+ Hits        16060    16061       +1     
- Misses      12252    12253       +1     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@veluca93
veluca93 force-pushed the fix-store-validation branch from 879a88d to 491ed4f Compare October 16, 2026 06:28
@veluca93
veluca93 enabled auto-merge (rebase) October 16, 2026 06:28
@veluca93
veluca93 merged commit 3277ca5 into cms-dev:main Oct 16, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants