Repository navigation
chore: remove stale json 3.x pin comment - #3054
Merged
Merged
Conversation
The comment explained why json was pinned to 2.x (json 3.0 made JSON.parse keyword-only, breaking ActiveSupport::JSON.decode). Rails 8.1.4 fixed the positional call and #3051 bumped json to ~> 3.1, so the pin rationale no longer applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the four-line Gemfile comment that explained the json 2.x pin from #2864. Rails 8.1.4 fixed the
ActiveSupport::JSON.decodebreak with json 3.x, and #3051 bumped json to~> 3.1, so the comment no longer describes the constraint above which it sits.Changes
gem 'json', '~> 3.1'in the Gemfile.Review notes