Repository navigation
fix(server): deprecate the i18n option the server never reads - #161
Merged
Merged
Conversation
anurag629
approved these changes
Oct 19, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @prakashNalla, this covers everything in #154. On top of current dev the build, typecheck and all 274 tests pass, and the warning test fails with dev's handler.ts. I updated the branch with dev so it could merge. Merging.
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
i18ninChatCopsServerConfignow has a@deprecatednote pointing to the widget'sstringsoption, andcreateChatHandlerlogs oneconsole.warnwhen it's set (once per handler, not per request). The type still accepts it. I took thei18nblock out of the setup example, marked it deprecated in the interface on that page, and updated the line about it inwidget/i18n.mdx(on top of #151).Closes #154
How I tested this
pnpm -r build,pnpm -r typecheckandpnpm test(29 files / 267 tests pass), on Node v22.23.3 with pnpm 9.15.0handler.test.ts: one warning wheni18nis set, none when it isn't. The first fails without the change.AI assistance
Claude helped me understand the issue
Checklist
devpnpm -r build,pnpm testandpnpm -r typecheckpass locallypnpm changeset) if this changescore,widgetorserver