Repository navigation
fix(forms): make "also available in" language link switch language - #1102
Merged
japsu merged 1 commit intoOct 26, 2026
Merged
Conversation
…nguage The link used next/link, so clicking it did a client-side transition to /<lang>/<path>. With localePrefix "never" the i18n proxy only switches the locale on a real request; the client transition just landed back on the unprefixed path in the old language. Use a plain <a> like the top bar language switcher does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Render alternate-language URLs as anchors kompassi-v2-frontend/src/components/forms/AlsoAvailableInLanguage.tsx |
The component removes the next/link import and uses plain anchors for alternate-language URLs. The localized destination and lang attribute remain. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Merge Risk: 
28c19
-
The language-switch links use full-page anchors as intended, so the PR is mergeable with normal checks.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main change: fixing the language link so it switches the form language. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "This form is also available in English" banner on surveys (and invitations) did nothing when clicked, while the top bar language switcher worked.
Cause: the banner used
next/link, so clicking did a client-side transition to/<lang>/<path>. With next-intllocalePrefix: "never", the locale only switches when the i18n proxy handles a real request (sets the locale cookie and redirects to the unprefixed path). The client-side transition just ended up on the same unprefixed URL in the old language.Fix: use a plain
<a>, the same as the top bar switcher inNavigationMenus.tsx.🤖 Generated with Claude Code
Summary by CodeRabbit