Repository navigation
fix: replace hardcoded credentials in tests with generated values (Snyk) - #218
Open
reeshika-h wants to merge 1 commit into
Open
reeshika-h wants to merge 1 commit into
reeshika-h wants to merge 1 commit into
Conversation
Replace hardcoded credentials, passwords, API keys and MFA secrets in the unit and integration tests with per-run generated values (TestSecrets helper) and remove the deepcode ignore suppression comments. Clears the Snyk Code NoHardcodedCredentials findings. Tests only; no change to the published package. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Snyk Code
NoHardcodedCredentialsfindings in this repo (91 findings, test code only).TestSecretshelper toContentstack.Management.Core.TestsandContentstack.Management.Core.Unit.Teststhat generates per-run values (password, email-shaped username, API-key-shaped value, token, valid/invalid base32 secret). None are real credentials.new NetworkCredential(...), API key / client secret / token variables and MFA secrets withTestSecrets.conststrings becamestatic readonly.LoginServiceTestasserts the exact request body, so its username/password are now shared fields used in the expected strings.// deepcode ignoresuppression comments from the test projects (suppression is not an approved fix).<EMAIL>) as literals; they are not credentials.No changes to
Contentstack.Management.CoreorContentstack.Management.ASPNETCore, so no version bump / changelog entry is needed (the version-bump check ignores the test projects).Verification
snyk code test --org=contentstack-developer-ecosystem: 0 issues (was 91).appSettings.jsonand live credentials; its login-failure scenarios use random credentials and should behave the same.🤖 Generated with Claude Code