Repository navigation
fix(deps): cap pyarrow below 26 on Python 3.12 - #140
Conversation
pyarrow 26.0.0 refuses to import with NumPy 1.x but doesn't declare a numpy requirement, and Python 3.12 is pinned to numpy<2. Fresh installs on 3.12 therefore resolved numpy 1.26.4 with pyarrow 26.0.0, and the chart and SQL functions failed to import. The locked pyarrow (24.0.0) already satisfies the cap, so poetry.lock only gets a new content-hash. Fixes #139 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
|
📦 Python package built successfully!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 120 120
Lines 6837 6837
Branches 990 990
=======================================
Hits 5345 5345
Misses 1182 1182
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
🚀 Review App Deployment Started
|
Every job that installs the toolkit's dependencies takes them from poetry.lock, so none of them saw pyarrow 26 break fresh pip installs on Python 3.12. The new job builds the wheel, installs it with its [server] extra into a clean venv without the lock on Python 3.10-3.14, and checks that DeepnoteChart, execute_sql and execute_sql_with_connection_json are exported. It checks the names because safe_import swallows import errors, so `import deepnote_toolkit` alone still succeeds when they fail. Refs #139 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
The one-line python -c check was hard to read. Running it as a heredoc script lets it use an if block and exit with a plain message instead of an AssertionError traceback, and leaves room for comments on why the step leaves the checkout and why it checks the exports by name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
The unit-test jobs install the project from the checkout and never build or install a wheel, so "wheel install" is what sets this job apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
|
@coderabbitai full review |
✅ Action performed
|
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Updates Docs |  |
The PR changes dependency constraints and CI only; it adds no documentation files. The required primary documentation and roadmap are in linked repositories, which are unavailable for inspection in th… | Verify and update the relevant documentation in the deepnote/deepnote OSS repository and the roadmap in the deepnote/deepnote-internal repository. Re-run this check when those repositories are available. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: capping pyarrow below version 26 for Python 3.12. Linked Issues check Issue #139requires a fix for fresh Python 3.12 installs with NumPy <2 and pyarrow 26.pyproject.tomlnow declarespyarrow>=23.0.1,<26for Python 3.12. The wheel-install check installs without `po…Out of Scope Changes check The changes stay within issue #139. The dependency constraint prevents the reported incompatible resolution. The CI job and import-check script provide automated coverage for the fresh-wheel installat…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Full details: Linked Issues check
-
Explanation
Issue
#139requires a fix for fresh Python 3.12 installs with NumPy <2 and pyarrow 26.pyproject.tomlnow declarespyarrow>=23.0.1,<26for Python 3.12. The wheel-install check installs withoutpoetry.lockand imports the affected toolkit APIs across Python 3.10–3.14. The reported Python 3.12 validation resolves pyarrow 25.0.1 and imports the affected APIs.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#139. The dependency constraint prevents the reported incompatible resolution. The CI job and import-check script provide automated coverage for the fresh-wheel installation path. The.flake8change supports that script. No unrelated change is demonstrated.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Full details: Updates Docs
-
Explanation
The PR changes dependency constraints and CI only; it adds no documentation files. The required primary documentation and roadmap are in linked repositories, which are unavailable for inspection in this review.
Resolution
Verify and update the relevant documentation in the deepnote/deepnote OSS repository and the roadmap in the deepnote/deepnote-internal repository. Re-run this check when those repositories are available.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…-3.12 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
…all check `import deepnote_toolkit` loads its public names through safe_import, which logs a failed import instead of raising, so the inline heredoc checked three of them with hasattr. scripts/check_toolkit_imports.py imports every name deepnote_toolkit/__init__.py loads, plus the artifacts functions, directly, so any broken dependency fails the job with its own traceback. Running the script by path keeps the checkout off sys.path, so the step no longer needs to cd out of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
Summary
Fixes #139.
Fresh installs of the toolkit on Python 3.12 get pyarrow 26.0.0, which refuses to import with NumPy 1.x, while 3.12 is pinned to
numpy<2. pyarrow 26 doesn't declare a numpy requirement, so pip doesn't catch the conflict, and the chart and SQL functions then fail to import. This PR caps pyarrow at<26on Python 3.12 only.Changes
pyproject.toml: the 3.12 requirement becomespyarrow>=23.0.1,<26, with a comment explaining why.poetry.lock: onlycontent-hashchanges. The locked pyarrow for Python 3.12 and later is already 24.0.0, so locked environments are unchanged. A plainpoetry lockalso drops about 20 unrelated duplicate entries (pydantic, pyzmq, shapely, …), the same thing it does onmain(see fix(deps): resolve pip-audit failures #133), so those were left alone.ci.yml: newwheel-install-checkjob (Wheel Install Check). Every other job that installs the toolkit's dependencies takes them frompoetry.lock, which is why CI didn't notice this break. For Python 3.10–3.14, the job builds the wheel, installs it with the[server]extra into a clean venv without the lock, and checks thatDeepnoteChart,execute_sqlandexecute_sql_with_connection_jsonare exported. It checks the names becausesafe_importswallows import errors, soimport deepnote_toolkitalone still succeeds when they fail. The job always resolves the latest upstream releases, so an upstream break can turn it red on PRs that didn't cause it.Python 3.10 and 3.11 already cap pyarrow at 18 or lower, and 3.13 and later require
numpy>=2.1, so no other version needs this.Why not NumPy 2 on 3.12
Allowing NumPy 2 on 3.12, as 3.13 and later already do, would also fix this. But it moves every 3.12 environment to a new NumPy major version, which breaks user code that relies on NumPy 1.x APIs removed in 2.0. It would also need pandas 2.2.2 or later on 3.12, where the floor is currently 2.1.0. That deserves its own PR.
The trade-off: until 3.12 moves to NumPy 2, it can't get pyarrow fixes released only in 26 or later.
Testing
pip install "deepnote-toolkit[server]==2.9.0"from PyPI into a fresh venv resolves numpy 1.26.4 with pyarrow 26.0.0, andDeepnoteChart,execute_sqlandexecute_sql_with_connection_jsonfail to import. A wheel built frommainbehaves the same.mainand are unrelated to pyarrow.poetry check --lockpasses.main's wheel, the same check fails withdeepnote_toolkit is missing exports: ['DeepnoteChart', 'execute_sql', 'execute_sql_with_connection_json'].actionlint1.7.12 and the pre-commit hooks pass onci.yml.The unit-test jobs install from
poetry.lock, which this PR doesn't change, so they run the same environment asmain. The fix is confirmed by the new Wheel Install Check job.🤖 Generated with Claude Code
https://claude.ai/code/session_01HwkxN8YriHhdXBwMc4sd8h
Summary by CodeRabbit