Repository navigation
Record why H6 reads no title by shape before a family comma - #724
Merged
Merged
Conversation
decisions/H6 point (1) gave only the doctrine and the absence of need for skipping H2's shape before a family comma. #710's close-out asked again whether `Xyz. Smith, John` could read title 'Xyz.'. There is a cost: a surname can open with an abbreviated word, and Filipino records write Santa and Santo as `Sta.` and `Sto.`, which the shape would take as titles (`Sta. Maria, Juan` -> title 'Sta.'). The decisions entry records the Census counts and what reopening would need. rules/H6's rationale names the class, and gains `Sta. Maria, Juan` as a boundary example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Juan Sta. Maria example presented a fix as a risk: today it already splits the surname (middle 'Sta.'), and particle status fixes it. The real open cost is P1's fold on a bare leading Sta, which the ambiguous listing avoids (both measured). Ste. Marie, Jean stays whole because ste is no title, not because of point (3)'s stop. The Census counts are bearers recorded with the abbreviation (Santa Maria is a separate 12,375-bearer entry). Mt./Ft. counts recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A shape peel gets a stop from a particle listing only if it keeps point (3)'s particle stop, which H2's comma-less head does not have (Ste. Marie Jean reads title 'Ste.'). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 46 46
Lines 4585 4585
=======================================
Hits 4541 4541
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
H6 (a title before a family comma) decided in #701 that only the title vocabulary claims a word before a family comma, never H2's period shape, so
Xyz. Smith, Johnkeeps familyXyz. Smith. The decisions entry gave two reasons, the doctrine (the slot is a surname's slot, as at H5) and the absence of need, and named no surname the shape would break. Closing #710 raised the question again ("surnames don't end in periods"). It turns out there is a cost:Sta.andSto., and H2's shape (two or more letters, one trailing period) claims both.Sta. Maria, Juanreads familySta. Mariatoday. With the shape rule it would read titleSta., familyMaria.tools/name_usage.py, 2026-10-18): Sta. Ana 408, Sta. Maria 376, Sto. Domingo 163, Sta. Cruz 110.steis a particle and no title, soSte. Marie, Jeannever enters H6's run.staandstoare in no vocabulary set.Santa Mariais its own entry (12,375 bearers), so these counts are the people recorded with the abbreviation.H6 stays as decided. This PR records the reason so it isn't asked a third time:
Juan Sta. Mariaalready splits the surname (middle 'Sta.', family 'Maria'). Listingsta/stoas particles fixes that (measured). As never-given particles, they'd make P1's fold take a bare leadingSta(Sta Juan→ family 'Sta Juan'). Listed as ambiguous, they keep given 'Sta' and add a report. Neither listing is decided here; that question is ShouldJuan Sta. Mariaread familySta. Maria? Today it reads middleSta., familyMaria#725."Sta. Maria, Juan" → family="Sta. Maria"joins the boundary examples, so the reading is now an executable pin.corpus_rules.jsonlandsnapshot.jsonleach gain the one new example name. No other reading moves.No parser code changes.
Review
The design-docs review found four inaccuracies in the first draft of the decisions entry, all fixed in 7d8be67: the
Juan Sta. Mariaexample, theSte.reason, how to read the Census counts, and the unmeasuredMt./Ft.counts. Its review of that fix commit came back clean, and ba7a3ba states the one condition it flagged.Test plan
uv run pytest: 21,314 passedSta. Maria, Juan)🤖 Generated with Claude Code