Skip to content

Revert #731's maiden-clause numeral fix; accept the shape in T4 - #733

Merged
derek73 merged 1 commit into
masterfrom
revert/issue-731-maiden-numeral
Oct 19, 2026
Merged

derek73 merged 1 commit into
masterfrom
revert/issue-731-maiden-numeral

Conversation

@derek73

@derek73 derek73 commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Reverts #732 (6008c8c), which fixed #731.

Why. rules/T4 and maiden names don't really interact: nobody writes a maiden marker followed by an initial, or two. #731 made john smith nee x x and john smith nee j x read as their capitals at a real cost:

  • a case argument on trailing_candidates and a whole-name case test in _maiden_take;
  • a stated exception to trailing_candidates' superset contract;
  • two grid shapes and a second invariant, each with its own control.

The gap #731 left open (a lowercase clause numeral behind capitals) would need the trailing peel to carry two case facts, one for S6's lean and one for the numeral. Neither is worth it for a shape names don't take.

What changes.

Kept from #732. rules/M2 names S10 among the trailing rules its take asks. That was true before #731, since the fork that reads a shape-only numeral is S10's.

Not touched. classify still reads a clause's letter by the whole name's case (#723's review). That guards a shape names do take: a connective inside a clause, MARIA GARCIA NEE LOPEZ y FERNANDEZ.

Full suite, mypy and ruff pass; the snapshot gains only the two Accepted examples.

🤖 Generated with Claude Code

Derek: rules/T4 and maiden names do not really interact, because
nobody writes a maiden marker followed by an initial. #731 (PR #732,
6008c8c) bought 'john smith nee x x' and 'john smith nee j x' their
capitals' reading with a case argument on trailing_candidates, a
whole-name case test in the take, an exception to the candidates'
superset contract, two grid shapes and a second invariant -- and the
gap it left would need the peel to carry two case facts. Reverted.

The readings go back to 2.2.0 through 2.4.2's ('john smith nee x x'
suffix 'x', maiden 'x'), stated as an Accepted clause of T4 with both
spellings as examples. Kept: M2 naming S10 among its trailing rules,
true before #731. decisions/T4 and decisions/M2 keep their #731
entries and gain superseding ones. Code and tests match ad486f6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added the bug label Oct 19, 2026
@derek73 derek73 self-assigned this Oct 19, 2026
@derek73 derek73 added this to the 2.5 milestone Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (6008c8c) to head (b8e5d63).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          46       46           
  Lines        4589     4589           
=======================================
  Hits         4545     4545           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit 09fc524 into master Oct 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should john smith nee x x read like JOHN SMITH NEE X X? A shape-only numeral in a maiden clause

1 participant