Repository navigation
Revert #731's maiden-clause numeral fix; accept the shape in T4 - #733
Merged
Merged
Conversation
Derek: rules/T4 and maiden names do not really interact, because nobody writes a maiden marker followed by an initial. #731 (PR #732, 6008c8c) bought 'john smith nee x x' and 'john smith nee j x' their capitals' reading with a case argument on trailing_candidates, a whole-name case test in the take, an exception to the candidates' superset contract, two grid shapes and a second invariant -- and the gap it left would need the peel to carry two case facts. Reverted. The readings go back to 2.2.0 through 2.4.2's ('john smith nee x x' suffix 'x', maiden 'x'), stated as an Accepted clause of T4 with both spellings as examples. Kept: M2 naming S10 among its trailing rules, true before #731. decisions/T4 and decisions/M2 keep their #731 entries and gain superseding ones. Code and tests match ad486f6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 46 46
Lines 4589 4589
=======================================
Hits 4545 4545
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #732 (6008c8c), which fixed #731.
Why. rules/T4 and maiden names don't really interact: nobody writes a maiden marker followed by an initial, or two. #731 made
john smith nee x xandjohn smith nee j xread as their capitals at a real cost:trailing_candidatesand a whole-name case test in_maiden_take;trailing_candidates' superset contract;The gap #731 left open (a lowercase clause numeral behind capitals) would need the trailing peel to carry two case facts, one for S6's lean and one for the numeral. Neither is worth it for a shape names don't take.
What changes.
john smith nee x xreads suffixx, maidenx, as 2.2.0 through 2.4.2 read it. rules/T4 states this as an Accepted clause, with both spellings as executable examples.john smith nee x xread likeJOHN SMITH NEE X X? A shape-only numeral in a maiden clause #731 comes off the Shouldj nee smithread likeJ NEE SMITH? A lowercase single letter isn't an initial in a one-case name #723 release bullet.john smith nee x xread likeJOHN SMITH NEE X X? A shape-only numeral in a maiden clause #731 entries (append-only) and gain superseding entries recording the decision.Kept from #732. rules/M2 names S10 among the trailing rules its take asks. That was true before #731, since the fork that reads a shape-only numeral is S10's.
Not touched. classify still reads a clause's letter by the whole name's case (#723's review). That guards a shape names do take: a connective inside a clause,
MARIA GARCIA NEE LOPEZ y FERNANDEZ.Full suite, mypy and ruff pass; the snapshot gains only the two Accepted examples.
🤖 Generated with Claude Code