Repository navigation
Give the conjunctions, bound given names and birth markers their languages (#751) - #780
Merged
Merged
Conversation
…uages (#751) The last 44 words in und.toml but bon and dí move to the files of the languages whose names they occur in, by the record each one carries: the #269/#397 conjunctions to en, fr, de, es, pt, it, ca, pl, ru, bg, uk, el and ar, with & in mul; the bound given names to ar; the birth markers by the #274 module docstring, with z domu in pl and 旧姓 in ja. ca.toml and nn.toml are new. No compiled set moves; the snapshot matches. The vetting comments become fields: notes and issues on the connectives, the y and Cyrillic may_be_initial keep-outs become exclusions, abd's comment is its note in ar.toml, and roz, removed from the birth markers on 2026-08-26, is an exclusion in cs.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ke f. a refusal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #751.
This moves the last 44 words out of
nameparser/vocab/und.tomlinto the files of the languages whose names they occur in. That leavesund.tomlwith onlybonanddí: two particles with no record of which names they come from, whose removal is #766's question. A comment at the top of the file says so.No compiled set moves.
tools/vocab/build.py --checkreports_compiled.pycurrent,tools/differential/snapshot.pymatches, and the word-order check passes.Where they went
Each word went where its own record put it:
Josep Carod i Rovirareads familyRovira— Catalan and Polish link surnames withi, which is not a conjunction #397 and their comments:and,of,theetundyeiиі,й,таκαιو&, a symbol no language ownsabu,أبوandابوjoin the teknonymic readings already in that file.née,né,neegeb,geborenegeboren, which the docstring calls Dutchrozenáfødtfødd(Nynorsk)föddz domu(parse("Maria Kowalska z domu Nowak") cannot reach the Polish maiden marker — markers do not compose the way suffixes do #434)旧姓(Should Japanese 旧姓 (former surname) populate the maiden field? (山田(旧姓:佐藤)) #309)ca.toml and nn.toml are new files.
Comments became fields
eandi, and its keep-outs,yand the Cyrillicи,іandй, areexcluded = { may_be_initial = … }.issueon each word, plus notes onі,وandعبد.abd's comment is now its note in ar.toml.same_as, for exampleabdel→abdul,й→і,nee→née, and the е spellings → the ё ones.rozin cs.toml, removed 2026-08-26. I measured it again: withrozlisted,Rosalind Roz Smithreads maiden 'Smith' and takes Rosalind for the family.f.in da.toml, which collides with the initial F.Docs
undparagraphs and the RFC's phase table are updated.Review
Two docs-review rounds, the second on the fix commit:
neewas placed against the docstring the entry cites, and that the en.tomlnée/néhad no gender. All three are fixed.Suite: 22,122 passed. mypy and ruff are clean.
🤖 Generated with Claude Code