Repository navigation
Migrate the T rules and W1, W2, W4 to the skeleton format (#761, part 7) - #782
Merged
Merged
Conversation
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eton format Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Strict mode now stands as a Precedence bullet citing C14. Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
T4: the bullet listing the rules that read a lower-case letter as its capital, and the case-question bullet, regain the scope their paragraph gave them; C14's strict mode goes back into the general suffix-veto clause, since T4 and C14 contest no input. T1: the opt-out bullet says only what the old statement did. Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ions A name the interpunct divides is inside each rule's When, and Then stops holding there, so it is an exception by the skeleton's own definition; the words and examples are unchanged. Dated decisions bullets record that move (W1, W4) and the decision to leave T1's strip_bidi=False half without an example. Three references to "W1's Accepted" / "W4's Accepted pair" are retargeted. Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cases.py's 间隔号 note cited W1 for an order claim W4's Except makes, and said source order where the rule says declared order. A test_lexicon.py comment cited rules/W1 for an NFD degradation that decisions/W1's ja-amendment bullet records. decisions/T1's new bullet now describes the example it declines. Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The surname-site comment that test_lexicon.py's pin supports cited rules/W1, which says nothing about NFD; both now name decisions/W1's 2026-07-29 NFD bullet (ja amendment 1a), the one of its two 2026-07-29 bullets that records the trade. Part of #761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #761.
Moves T1–T5 (tokens, initials and punctuation) and W1, W2, W4 (scripts) from the block format to the skeleton format, one commit per rule. Four more commits follow: review fixes, and one carrying Derek's decisions (below). W3 was already a skeleton rule. Its full-stop split is Derek's call and is not touched here.
No rule changes meaning. Every rule's example lines are the same multiset as on master (checked per commit),
corpus_rules.jsonlregenerates with no diff, and no code-comment quote needed retargeting: each quoted clause kept its verbatim home in Then or a bullet.tests/v2/rules_budget.jsonis re-recorded, one row per rule commit, each row changing format.Per rule
keep-emoji) is an Except. It's an input inside When where Then stops holding.no-boundary:waiver.Gal·laboundary stays in the main fence, because Then's "anywhere else" clause still holds for it.Strict mode in T4 and W2
john smith, vgives givenv, the same reading asJOHN SMITH, V. Mixed-caseJohn Smith, vkeeps suffixv.田中さん vand田中さん Vread alike under both settings. The switch reaches the peel only across a comma, and that is W3's existing Precedence bullet. So W2 needed no C14 bullet.Old
interacts:IDsdecisions/W3pointer the statement already carried; W3 names W1 from its sideDecided (Derek, 2026-10-20)
character:, translating the block format's "a character:". README's tag list was already missingseparator(C10). The list gets fixed in the final Give rule blocks a skeleton: Rule, Except, Precedence #761 PR, the one that retires the block format. Not here.tests/v2/cases.py, intests/v2/pipeline/test_script_segment.pyand in decisions/T3.strip_bidi=Falsehalf stays without an example. A corpus name made of invisible direction marks is not worth a new policy annotation. A dated bullet in decisions/T1 records this.Review
Two docs-review rounds.
tests/v2/cases.py's 间隔号 note had cited W1 for an order claim, which belongs to W4's Except and is about declared order, not source order. The note was wrong before this PR too. It also found atest_lexicon.pycomment that cited rules/W1 for the NFD degradation that decisions/W1 records, and that decisions/T1's new bullet misdescribed the example it declines. All were fixed in e51b1e9._script_segment.py, and "the 2026-07-29 ja-amendment bullet" matched two bullets. Both were fixed in e47e0e3, a two-line comment change that names decisions/W1's NFD bullet (ja amendment 1a). That commit itself has not had a review round.The suite (22,157 passed), mypy and ruff are clean.
🤖 Generated with Claude Code