Repository navigation
fix(deps): require certifi>=2026.10.19 to distrust compromised eMudhra CAs - #1734
Merged
Merged
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. 🤖 Model: Review scope: Full review Reviewed files (2)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK builds its SSL context from
certifi.where()(descope/_http_client_base.py), so it does not use the OS trust store. certifi releases before 2026.10.19 still trust the roots (emSign ECC Root CA - G3,AAA Certificate Services) that chain to the eight compromised eMudhra intermediates (https://emudhra.we-have-a-problem.com/).>=2026.10.19so installs cannot resolve a vulnerable bundle.uv.lockcertifi 2026.6.17 -> 2026.10.19 (certifi only, no other lock changes).No open Renovate PR raised the floor. #1617 (lock-file maintenance) bumps the lock but leaves the
pyproject.tomlfloor unchanged, so consumers could still resolve a vulnerable certifi.Verification: the bundled
cacert.pemin certifi 2026.10.19 contains neither root. Unit tests: 1140 passed, 1 failed (test_base_url_resolves_every_region,KeyError: 'REGIONS', an environment variable not set locally; the failure does not touch this change). e2e and flask tests not run.