Skip to content

perf(ci): bound parallel regression execution - #5558

Merged
devantler merged 15 commits into
mainfrom
codex/ci-auth-fixture-timing-5495
Oct 29, 2026
Merged

devantler merged 15 commits into
mainfrom
codex/ci-auth-fixture-timing-5495

Conversation

@devantler

@devantler devantler commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Slow independent validation delays platform delivery and recovery.

What

Use bounded concurrency for existing regression checks and run independent validation in two isolated groups, preserving every check and deadline. A matched local comparison improved the slowest suite from 407s to 245s; hosted feedback and total delivery time remain to be verified.

Part of #5495

Part of #5495. Preserve the complete suite, dependency startup controls and package deadline while allowing eight already parallel test cases per package.
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T10:50:52.792268Z 8418cdc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 8418cdcfd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review October 29, 2026 10:59
@devantler
devantler added this pull request to the merge queue Oct 29, 2026
@devantler
devantler removed this pull request from the merge queue due to a manual request Oct 29, 2026
@devantler

devantler commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocker: none

Cleared 2026-10-29: Runner repair #5559 merged at 0fd031e; the merge-group and actual merged-source browser runs, Validate Main, CodeQL and Code Quality all passed. Resume on that reviewed base and renew exact-head CI, independent review and readiness before protected queue entry.

Previous record (historical):

> 🤖 Generated by the Agentic Engineer

<!-- pr-blocker-record -->

**Blocker:** devantler-tech/platform#5559 | upstream | last-verified 2026-10-29: Merge-group 40875591717 at be94f92c01 failed browser installation: Playwright 1.56.1 does not support Ubuntu 26.04. The same workflow blob is on main and both queued branches. Removed before the production job started; require #5559 merged and fresh successful current-base CI before requeue.

@devantler
devantler marked this pull request as draft October 29, 2026 14:58
@devantler devantler removed the blocked label Oct 29, 2026
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0fd031e and dce945e.

Files selected for processing: 7
  • .github/workflows/ci.yaml
  • AGENTS.md
  • docs/adr/ci-regression-partitions.md
  • scripts/guard-arc-recovery/ci_dependency_test.go
  • scripts/tests/test-policy-ci-job.sh
  • scripts/tests/test-private-mail-configuration.sh
  • scripts/validate-merge-group-heal/go_regressions_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: CodeRabbit
Additional comments: 5
scripts/tests/test-private-mail-configuration.sh: 1

101-107: LGTM!

.github/workflows/ci.yaml: 2

108-110: LGTM!

Also applies to: 112-112

3385-3385: LGTM!

Also applies to: 3389-3395, 3417-3417, 3448-3448, 3454-3454, 3460-3460, 3468-3468, 3471-3471, 3477-3477, 3484-3484, 3491-3491, 3500-3500, 3512-3512

scripts/guard-arc-recovery/ci_dependency_test.go: 1

33-33: LGTM!

scripts/validate-merge-group-heal/go_regressions_test.go: 1

66-67: LGTM!

Also applies to: 69-69

Walkthrough

The full Go regression command now uses -parallel 8 and retains its 20-minute timeout. The manifest regression job now runs contracts and native matrix suites, with up to two jobs in parallel. Regression routing checks and documentation cover eleven checks and the matrix settings. Bootstrap image verification now checks additional assets and reports distinct failure markers.

Possibly related PRs

Priority: Low

Merge Risk: Minimal · up to dce94

The regressions remain selected and are split across two runners. No actionable merge blocker was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "perf(ci): bound parallel regression execution" matches the main change. The diff caps parallelism for the Go regression suite with -parallel 8 and splits manifest regression validation into…
Description check Passed The description states the purpose (slow independent validation delays delivery and recovery) and the change (bounded concurrency for existing regression checks, run in two isolated groups, with every…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "perf(ci): bound parallel regression execution" matches the main change. The diff caps parallelism for the Go regression suite with -parallel 8 and splits manifest regression validation into a two-suite matrix (contracts, native) with max-parallel of two. The title is short, specific, and follows Conventional Commits.

Full details: Description check

Explanation

The description states the purpose (slow independent validation delays delivery and recovery) and the change (bounded concurrency for existing regression checks, run in two isolated groups, with every check and deadline preserved). It also gives a local timing comparison and notes that hosted feedback is unverified. This relates directly to the changeset, so the check passes.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 4 files. (3 skipped: 3 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at dce945e71289ae9fc56e46312e6e2695ccba6642: the complete current-head CI exercised the changed regression partitioning and passed; the reported checks are settled at 45 success/9 skipped. The current-head CodeRabbit review is finding-free and the canonical verdict helper returns GREEN. Fresh native reads show zero review threads, MERGEABLE/CLEAN, no outstanding maintainer instruction and this session's own worktree holder.

As the pipeline's user, I observed the complete hosted workflow and retained regression execution, plus the earlier 582-case/race validation of the unchanged authorization test inputs. The measured 407s-to-245s package result is scoped to that package; repository guards were the longest current CI job at 663s. Overall pipeline acceptance remains open on #5495.

Live main is now 3fe270060fe86bae178f29eda1e3e4a061202b5f: its actual merged-source deployment passed all 17 public checks, post-merge Validate Main/CodeQL/Code Quality passed, and live health is OK. A conflict-free merge preview retains the new main mail-recovery selection. Actionlint passes with the repository's reviewed configuration and its separate concurrency enum validator also passes; the standalone temporary-file lint lacked that configuration. The protected merge queue will validate the full combination again.

@devantler
devantler marked this pull request as ready for review October 29, 2026 16:28
@devantler
devantler added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 608f331 Oct 29, 2026
54 checks passed
@devantler
devantler deleted the codex/ci-auth-fixture-timing-5495 branch October 29, 2026 19:28
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant