Skip to content

chore(help): list iphone-duo in the --ios-device help text - #284

Merged
finalerock44 merged 2 commits into
devfrom
chore/iphone-duo-help
Oct 28, 2026
Merged

finalerock44 merged 2 commits into
devfrom
chore/iphone-duo-help

Conversation

@finalerock44

Copy link
Copy Markdown
Contributor

The device enum only feeds --help; validation runs against the live compatibility payload, which advertises the iPhone Duo since the production API deploy on 2026-10-27.

What & why

Type of change

  • fix — bug fix
  • feat — new feature
  • perf — performance improvement
  • refactor — code change that's neither a fix nor a feature
  • docs — documentation only
  • chore / ci / build / test — tooling, no user-facing change
  • Breaking change (title has ! or PR notes a BREAKING CHANGE:)

Checklist

  • PR title follows the Conventional Commits format (see comment above)
  • pnpm lint passes
  • pnpm typecheck passes
  • pnpm build passes
  • I have not bumped the version or edited CHANGELOG.md (release-please handles this)
  • I have signed the CLA (the bot will prompt on first contribution)
  • Docs / README.md / STYLE_GUIDE.md updated if behaviour or output changed

How to test

The device enum only feeds --help; validation runs against the live
compatibility payload, which advertises the iPhone Duo since the
production API deploy on 2026-10-27.
@finalerock44 finalerock44 self-assigned this Oct 28, 2026
@claude

claude Bot commented Oct 28, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

This is a trivial one-line change, so I didn't run the full multi-agent review. It adds iphone-duo to EiOSDevices, which only feeds the --ios-device help text (src/config/flags/device.flags.ts). Validation runs against the live compatibility payload, and the one unit test that reads the enum only checks that iphone-19 is absent, so the new entry doesn't affect it.

🤖 Generated with Claude Code

@finalerock44
finalerock44 merged commit e289df5 into dev Oct 28, 2026
9 checks passed
@finalerock44
finalerock44 deleted the chore/iphone-duo-help branch October 28, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant