Skip to content

fix(tui): clean up the settings dialog - #4599

Merged
dgageot merged 8 commits into
docker:mainfrom
dgageot:worktree-board-c871702d1e673f9f
Oct 15, 2026
Merged

dgageot merged 8 commits into
docker:mainfrom
dgageot:worktree-board-c871702d1e673f9f

Conversation

@dgageot

@dgageot dgageot commented Oct 15, 2026

Copy link
Copy Markdown
Member

Summary

Redesigns the TUI settings dialog so it adapts cleanly to terminal size while
staying easy to scan:

  • Responsive layout that stays compact on narrow terminals and keeps stable
    geometry across category switches
  • Controls within a section are now grouped contiguously, with the help text
    fixed in place
  • Category tabs are clickable, with coordinate tracking that accounts for
    drag/resize
  • On wide terminals, the layout preview is detached for better readability
  • Focus highlighting fixed
  • Removed a redundant tip in the theme picker

Existing preference effects are unchanged — only the dialog's layout and
interaction model changed.

Test checklist

  • task build
  • task test
  • task lint (golangci-lint v2.14 via PATH=$PWD/.cache/tools:$PATH)
  • Narrow and wide terminal sizing
  • Stable category dimensions and position when switching tabs
  • Click handling, including after drag/resize
  • Confirmation safety (no accidental dismiss/apply)
  • Nine golden snapshots across light/dark themes
  • Docs updated (docs/features/tui/index.md)

@dgageot
dgageot requested a review from a team as a code owner October 15, 2026 14:12
@aheritier aheritier added area/docs Documentation changes area/tui For features/issues/fixes related to the TUI kind/fix PR fixes a bug (maps to fix:). Use on PRs only. labels Oct 15, 2026
@dgageot
dgageot added this pull request to the merge queue Oct 15, 2026
Merged via the queue into docker:main with commit 19fa4a1 Oct 15, 2026
22 checks passed
@dgageot
dgageot deleted the worktree-board-c871702d1e673f9f branch October 15, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation changes area/tui For features/issues/fixes related to the TUI kind/fix PR fixes a bug (maps to fix:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants