Repository navigation
Fix producer flush hangs when undrained batches expire - #3165
Merged
Merged
Conversation
Owner
|
Thanks! (test failures in CI are unrelated and have been fixed on master). |
dpkp
pushed a commit
that referenced
this pull request
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing an undrained expired batch with message ordering enabled removes a partition that was never muted. The resulting
KeyErrorinterrupts expiry processing, leaving other batches' futures unresolved and causingflush()to wait indefinitely.Use
discard()when unmuting partitions in both completion paths. Regression tests cover multiple undrained expired batches, late success/error responses after expiry, and normal successful completion with message ordering enabled or disabled.Fixes #3159.
Validation:
KeyErroron unmodified master and pass with the fix.pytest -q test --ignore=test/integration: 2743 passed, 1 skipped (Python 3.12.13).make lintandgit diff --checkpassed.Kafka broker integration tests were not run locally.
CI note: all 13 failing matrix jobs report
test/net/backend/test_transport.py::TestKafkaTCPTransport::test_ssl_wrapper_transportraisingValueError: check_hostname requires server_hostname. The same test fails on clean basecd3f7938and PR head70d9c08ewith Python 3.13.16 and the same development dependencies. This failure is independent of the producer expiry change.