Repository navigation
Fix test_ssl_wrapper_transport on Python 3.13.16+/3.14.8+ - #3172
Merged
dpkp merged 1 commit intoOct 24, 2026
Merged
Conversation
The new CPython patch version does the `SSLObject` parameter checks at `wrap_bio()` time and throws an error like "ValueError: check_hostname requires server_hostname". This happens when the `check_hostname` is set but there is no `server_hostname`. Our test creates `KafkaSSLTransport` with no host set but with `ssl_check_hostname=True` (default value). Fixed by setting a host a host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new CPython patch version does the
SSLObjectparameter checks atwrap_bio()time and throws an error like "ValueError: check_hostname requires server_hostname". This happens when thecheck_hostnameis set but there is noserver_hostname. Our test createsKafkaSSLTransportwith no host set but withssl_check_hostname=True(default value). Fixed by setting a host a host.