Repository navigation
iommu/xen: take the old domain in attach_dev - #58
Merged
graysonguarino merged 1 commit intoOct 26, 2026
Merged
Conversation
Linux 6.18.58 passes the device's old domain to the attach_dev callback as a third argument. xen-iommu still had the two-argument form, so x86_64 builds with CONFIG_XEN_IOMMU fail with -Werror=incompatible-pointer-types since the rebase onto 6.18.58. The driver does not need the old domain. This matches xen-iommu.c on edera/mainline, whose upstream base already had the three-argument form. Signed-off-by: Grayson Guarino <graysonguarino@gmail.com>
Author
|
x86_64 |
antoineco
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux 6.18.58 adds a third
struct iommu_domain *oldargument to theattach_devcallback.xen-iommu.cstill had the two-argument form, so every x86_64 build withCONFIG_XEN_IOMMUhas failed with-Werror=incompatible-pointer-typessince the rebase onto 6.18.58 (#47). That covers the build in #47 itself and every x86_64 image in edera-dev/linux-kernel-oci (host,zone,zone-nvidiagpu,zone-kvm).LTS-only:
xen-iommu.conedera/mainlinealready takes the old domain, and this makes the LTS file identical to it.Testing
Built in edera-dev/linux-kernel-oci's pinned
kernel-buildenvimage withmake -k, so no other error hides behind this one:zoneconfig,vmlinux modules: builds, withCONFIG_XEN_IOMMU=y.hostconfig: in progress, I'll comment with the result.