Repository navigation
fix(precompiles): reject state changes in static calls to mint writers - #422
Merged
Merged
Conversation
The mint precompile's writer methods (mint, burn, addToAllowList, removeFromAllowList) did not check `is_static`, so they could commit state inside a STATICCALL frame. The proposer and deploy_permissions precompiles already reject this; mirror the same guard here. Adds a regression test covering the static-call path.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
tac0turtle
approved these changes
Oct 27, 2026
tac0turtle
enabled auto-merge (squash)
October 27, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mint precompile's writer methods (mint, burn, addToAllowList, removeFromAllowList) did not check
is_static, so they could commit state inside a STATICCALL frame. The proposer and deploy_permissions precompiles already reject this; mirror the same guard here.Adds a regression test covering the static-call path.
Type of Change
Related Issues
Fixes #(issue)
Checklist
Testing
Additional Notes