Repository navigation
fix: canonicalize evnode sponsor signatures and strictly decode payload txs - #426
Merged
tac0turtle merged 2 commits intoOct 27, 2026
Merged
Conversation
…ad txs - decode_optional_signature rejects non-canonical signature encodings (e.g. v = 0/1 or EIP-155) by requiring the bytes to round-trip, so a sponsor signature has a single valid encoding and transaction hash. - recover_sponsor rejects malleable high-s signatures (EIP-2), matching the executor recovery path. - payload transactions are decoded with decode_2718_exact so trailing bytes after a transaction are rejected instead of silently ignored. Adds regression tests for each.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
…ct decode The non-canonical-v check required the as_bytes() form (v = 27/28), but clients encode the fee-payer signature with v = 0/1 (matching the executor signature), so valid sponsored transactions were rejected. Enforcing a single canonical v requires aligning the encoder, decoder, and tx hash on one form, which is a protocol-level change; defer it. The high-s (EIP-2) sponsor check and strict decode_2718_exact are kept. Also applies cargo fmt.
tac0turtle
approved these changes
Oct 27, 2026
tac0turtle
deleted the
fix/canonical-sponsor-signature-and-strict-decode
branch
October 27, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for each.
Type of Change
Related Issues
Fixes #(issue)
Checklist
Testing
Additional Notes