Repository navigation
fix(code): list repositories without an owner again - #232
Merged
Merged
Conversation
`stack code repo list` with no owner failed with "'str' object has no
attribute 'get'". Forgejo's repository search answers with an envelope,
`{"ok": true, "data": [...]}`, and the client returned that envelope as
the list, so the command walked its keys instead of the repositories.
The client now returns the `data` array. Listing one owner's
repositories was unaffected: that endpoint answers with a bare array.
The command also returns what it listed, so `--json` prints the
repositories instead of an empty object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack code repo listwithout an owner crashed with'str' object has no attribute 'get'. Forgejo's/repos/searchanswers{"ok": true, "data": [...]}(theSearchResultsschema), andForgejoClient.list_reposreturned that envelope as the list. It now returnsdata. The per-owner path (/users/{owner}/repos) is a bare array and was fine.{"repos": [...]}, so--jsonprints the repositories instead of{}.