Repository navigation
refactor(ai): take the speech pace and voice from one place - #238
Merged
Merged
Conversation
`stack ai hello` carried its own copy of the voice rule, the 0.8 pace and the request to the speech server, and `stack ai say` matched it only because the shared helper defaulted to the same number. The pace is now one named value in the speech helper, chosen by ear for the welcome message, and `hello`, `intro` and `say` all use it and the shared voice rule. No behaviour change.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./stack ai hellohad its own copy of the voice rule, the 0.8 pace and the speech request, so./stack ai saysounded the same only by coincidence. The pace is now one named value in the shared speech helper, the one chosen by ear for the welcome message, andhello,introandsayuse it together with the shared voice rule.sayandhellorequested and expects the same voice and pace from both. No behaviour change.