Repository navigation
feat: Alt+M toggles reviewed on selected file - #127
Merged
Merged
Conversation
Marking advances to the next file when reviewed files are shown; unmarking and the header button keep selection. Header button and shortcut share one toggle rule in useFileNavigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use-file-navigation.ts): reviewing from the keyboard no longer needs the header button. It acts onactivePath, the same file Alt+J/K moves, and is skipped in text fields, on key repeat, while that file's mark write is in flight, and in read-only commit views.toggleFileReviewed(file, { advance })inuseFileNavigation: the header button and the shortcut now use one rule, which keeps a marked file's collapsed header at the viewport top. With reviewed files shown, the shortcut moves selection to the next file after the server confirms the mark. Unmarking, the button, and the last file keep selection. With reviewed files hidden, the existing handoff to the neighbor still applies.DiffWorkspace.tsx): the footer showsAlt+M reviewedoutside commit views, and the Reviewed button has a tooltip with the shortcut.DESIGN.mdnavigation rules anddocs-websitereviewing-changes page.mise run checkpasses. New browser test covers mark+advance, unmark, filter field, last file, hidden reviewed files, tooltip and footer. The commit-view test asserts Alt+M sends no mark write and shows no hint. With the source change reverted, the new test fails.