Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DESIGN.md
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,9 @@ Do not add motion for decoration. New animation must honor
- Skeletons use `--border-muted`, existing spacing and radius tokens, and a gentle
shared opacity pulse. Disable animation under `prefers-reduced-motion`. Keep
placeholders out of the accessibility tree and tab order; label the busy region
with a concise status at the bottom of the review surface. Do not invent file
with a concise status at the bottom of the review surface. Its detail line
pulses between `--fg` and `--muted` on the skeleton rhythm, static under
reduced motion. Do not invent file
names, counts, progress percentages or addition/deletion colors.
- Replace skeletons as data arrives, without a minimum display delay. Stored
manifest loading uses the same diff-frame skeleton without unmounting Pierre.
Expand Down
4 changes: 3 additions & 1 deletion apps/web/src/WorkspaceLoading.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ export function WorkspaceLoading({ collecting }: { collecting: boolean }) {
<DiffSkeleton />
<div className="loading-status">
<h1>{collecting ? "Collecting latest changes" : "Loading review"}</h1>
<p>{collecting ? "Reading checkouts…" : "Reading stored changes…"}</p>
<p className="motion-safe:animate-status-pulse">
{collecting ? "Reading checkouts…" : "Reading stored changes…"}
</p>
<span className="ml-auto flex items-center">
<SettingsButton />
</span>
Expand Down
7 changes: 7 additions & 0 deletions apps/web/src/loading.css
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,13 @@
opacity: 0.45;
}
}
/* Referenced by the loading status's animate-status-pulse utility. Shares the
skeleton rhythm; dims only to --muted so the text stays legible. */
@keyframes status-pulse {
50% {
color: var(--muted);
}
}
@media (max-width: 1011px) {
.loading-sidebar {
display: none;
Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,8 @@ main {
--color-backdrop: var(--backdrop);
--animate-spinner: refresh-spin var(--duration-spin) linear infinite;
--animate-skeleton: skeleton-pulse var(--duration-pulse) ease-in-out infinite;
--animate-status-pulse: status-pulse var(--duration-pulse) ease-in-out
infinite;
}

@layer base {
Expand Down
Loading