Repository navigation
Fix crash on Play Game from reversed random bounds - #218
Merged
Merged
Conversation
LightingTest passed a min.z greater than max.z to Random::GetRandomVec3. MSVC's uniform_real_distribution asserts min <= max in Debug, so the editor crashed when it started the game. Fix the Sandbox bounds, and make Random/RandomStream sort the bounds before they build a distribution so reversed bounds can never crash. Add regression tests for reversed and equal bounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::uniform_real_distribution(min <= max).Sandbox::Game::LightingTestpassedmin.z = 15andmax.z = -15toRandom::GetRandomVec3.LightingTestare now in the right order. The spawn area is the same.RandomBetweenandGetRandomFloatnow sort their bounds withstd::minmaxbefore they build the distribution.GetRandomVec3callsGetRandomFloat, so it is covered too. This applies to bothRandomandRandomStream. Before, reversed bounds were undefined behavior and asserted in Debug. The header docs now say the bounds can be in either order.Test plan
CoreTests.exe "[utils]"(Debug, MSVC): all 17830 assertions in 8 test cases passscripts/check_comment_style.pypasses🤖 Generated with Claude Code