Repository navigation
fix(flow-php/etl): PSRCacheBuckets keys use PSR-16 reserved characters - #2701
Merged
Merged
Conversation
- separate keys with dots, default prefix flow.buckets - reject prefixes with reserved characters - test against filesystem cache instead of Redis - remove Redis from dev environment and CI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2701 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 2212 2212
Lines 85809 85811 +2
=======================================
+ Hits 77260 77262 +2
Misses 8549 8549 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/etl- PSRCacheBuckets rejects prefixes containing PSR-16 reserved charactersFixed
flow-php/etl- PSRCacheBuckets keys no longer contain PSR-16 reserved charactersChanged
flow-php/etl- PSRCacheBuckets default prefix changed from flow:buckets to flow.bucketsRemoved
flow-php/etl- Redis from the dev environment, CI and testsDeprecated
Security