Repository navigation
feat: add skills.sh.json grouping and validation test - #249
Conversation
- Add `skills.sh.json` grouping the 10 Flutter skills (`UI & Layout`, `Architecture & Data`, `Testing & Previews`) and 15 synced Dart skills (`Dart Language`, `Dart Testing`, `Dart Analysis`, `Dart Interop`) while setting `notGrouped: "bottom"` to demote 64 legacy/renamed slugs on `skills.sh/flutter/agent-plugins`. - Extend `tool/generator/test/lint_skills_test.dart` and `.github/workflows/skills_tool.yaml` to verify that `skills.sh.json` and `README.md` stay synchronized with `skills/`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new skills.sh.json file defining various skill groups and introduces a validation test in lint_skills_test.dart to verify its structure and consistency. A review comment identifies a bug in the test where the assertion comparing groupedSkills to actualSkills will fail because groupedSkills contains both Dart and Flutter skills, while actualSkills only contains local Flutter skills. The reviewer suggests filtering groupedSkills to only include Flutter skills before the comparison.
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
Finally if there is a best practice for what to do when renaming or deleting published skills we might want that documented someplace. Im
…ation - Remove the 4 synced `Dart *` groups from `skills.sh.json` so only the 10 `flutter-*` skills are grouped at the top (`UI & Layout`, `Architecture & Data`, `Testing & Previews`) and synced `dart-*` skills fall into `notGrouped: "bottom"` alongside retired legacy slugs. - Place `"notGrouped": "bottom"` at the end of `skills.sh.json`. - Remove the `paths:` filter on `pull_request` and `push` in `.github/workflows/skills_tool.yaml`. - Clarify validation steps and local string comparison (zero network calls) in `tool/generator/test/lint_skills_test.dart`. - Document how to update `README.md` and `skills.sh.json` when adding, renaming, or deleting skills in `tool/generator/README.md`.
|
Added a section in tool/generator/README.md in d42bbb1 documenting what to update when adding, renaming, or deleting published skills and how skills.sh.json handles retired skill slugs. |
|
Some feedback in dart-lang/skills#54 that could also apply here for how to write better test code (or at least more human test code). |
|
LGTM, is there a reason we aren't including the Dart skills also? |
|
Applied the test readability improvements from Re: Dart skills — per earlier review discussion (#249 (comment)), |
3 participants
Groups the 10
flutter-*skills (UI & Layout,Architecture & Data,Testing & Previews) on https://www.skills.sh/flutter/agent-plugins viaskills.sh.json(https://www.skills.sh/docs/customize) and setsnotGrouped: "bottom".skills.sh) and the 15 synceddart-*copies (canonical indart-lang/skills) intoOther skillsat the bottom so only the 10flutter-*skills are featured in top-level groups.tool/generator/test/lint_skills_test.dart,tool/generator/README.md, and.github/workflows/skills_tool.yamlsoskills.sh.jsonandREADME.mdstay in sync with theflutter-*directories inskills/.