Repository navigation
Place underline, strike and link rectangles from the baseline-adjusted line top - #1830
Merged
blikblum merged 1 commit intoOct 26, 2026
Merged
Conversation
…d line top With a baseline other than the default the glyphs move up by the ascent, but the decorations and the link and goTo rectangles were still measured from the top of the line box, so they sat an ascent too low. Fixes foliojs#994, foliojs#1245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Fixes #994 and #1245.
With
baselineset to anything other than the default, the glyphs are drawn an ascent higher than the top of the line box, but the underline, the strike-through and the link andgoTorectangles were still measured from the top of the line, so they ended up an ascent too low (the underline sits well below the text withalphabetic, as in the screenshots on #994). This moves all four onto the same baseline-adjusted line top that_fragmentalready derivesdyfrom, so the default baseline is unchanged and the others line up.The new test fails on master (underline y 60.1 with
alphabeticwhere 51.484 is right at 12pt Helvetica, one ascent off) and passes with the change. The rest of the unit and visual suites pass too.Checklist: