Repository navigation
Render SVG quadratic curves with equivalent cubic controls - #1835
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Fixes #550.
SVG
Q/qandT/tcommands used PDF'svoperator, which describes a cubic curve with its first control point at the current point. That changes the shape of a quadratic curve: the forward and reversed paths in #550 do not overlap.Convert those commands to equivalent cubic controls using the current point already tracked by the SVG parser. Smooth quadratic commands reuse the same conversion and keep the preceding quadratic control point for reflection. This change is limited to SVG paths; the standalone
quadraticCurveTo()API is unchanged.The seven new path tests fail on the base and pass with the fix. The rendered forward and reverse paths from the issue now overlap.
yarn test:unit(533 tests),yarn lint,yarn build.Checklist: