Skip to content

feat(effects): the Effects lane and the effect inspector - #1235

Merged
EtienneLescot merged 1 commit into
integration/shader-effectsfrom
feat/shader-effects-ui
Oct 14, 2026
Merged

EtienneLescot merged 1 commit into
integration/shader-effectsfrom
feat/shader-effects-ui

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

PR 6 of the shader effects stack (docs/shader-effects.md, part F). Part of #1210.

What the user sees

  • One Effects lane under Full Camera. It shows only while the project has an effect, since only an agent adds them.
  • Each pill carries the effect's name. It moves, resizes, copies, pastes and deletes like the other regions. A paste onto another effect is refused with a toast (one effect at a time, K.6).
  • The inspector edits the effect's parameters (slider, toggle, colour, point) and its target (image, text, both), shows its cost tier and its code with a copy button, and reports a compile error found by the compositor addon.

How

  • useTimeline: updateShaderEffectSpan, updateShaderEffect, and a live path (updateShaderEffectLive then commitShaderEffectChange) so a slider drag is one undo step. Rows added to documentWriteAudit.test.ts.
  • checkShaderEffect goes through the native bridge to compositorViewService.checkShaderEffect.
  • Copy and paste carry the definition, so a paste into another project recreates it (withPastedShaderEffect).
  • 15 locales: the inspector.effect* keys and regionClipboard.pasteEffectOverlap.

Checks

  • npm run test: 4794 passed.
  • tsc root, tests, workbench, node: clean. Biome: no new warning.

The website docs page follows in a separate PR.

🤖 Generated with Claude Code

One Effects lane under Full Camera, shown only while the project has an effect. Its pills move, resize, copy, paste and delete like the other regions, and a paste onto another effect is refused. The inspector edits the effect's parameters and target, shows its cost tier and its code, and reports a compile error the compositor finds.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 92423553-d568-4aec-894e-2da8dc96105c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 2b998cd into integration/shader-effects Oct 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant