Repository navigation
feat(effects): the Effects lane and the effect inspector - #1235
Merged
Merged
Conversation
One Effects lane under Full Camera, shown only while the project has an effect. Its pills move, resize, copy, paste and delete like the other regions, and a paste onto another effect is refused. The inspector edits the effect's parameters and target, shows its cost tier and its code, and reports a compile error the compositor finds.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6 of the shader effects stack (docs/shader-effects.md, part F). Part of #1210.
What the user sees
How
useTimeline:updateShaderEffectSpan,updateShaderEffect, and a live path (updateShaderEffectLivethencommitShaderEffectChange) so a slider drag is one undo step. Rows added todocumentWriteAudit.test.ts.checkShaderEffectgoes through the native bridge tocompositorViewService.checkShaderEffect.withPastedShaderEffect).inspector.effect*keys andregionClipboard.pasteEffectOverlap.Checks
npm run test: 4794 passed.tscroot, tests, workbench, node: clean. Biome: no new warning.The website docs page follows in a separate PR.
🤖 Generated with Claude Code