Repository navigation
ref(aws-lambda): Refactor aws-lambda integration - #7938
Conversation
Coverage Results 📊✅ 56198 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 59071 | Pass Rate: 95.14% | Execution Time: 154m 3s 📊 Comparison with Base Branch
❌ Patch coverage is 39.83% (94 of 236 changed executable lines covered; target 80%). Changed files with executable lines (6)
Coverage diff@@ Coverage Diff @@
## master #7938 +/-##
==========================================
- Coverage 90.25% 90.04% -0.21%
==========================================
Files 202 197 -5
Tracked lines 26660 20950 -5710
Branches 9926 7206 -2720
==========================================
- Hits 24062 18864 -5198
+ Misses 2598 2086 -512
+ Partials 1510 1234 -276Generated by Coverage Action |
81e5cb8 to
83361bb
Compare
83361bb to
e3dabcd
Compare
sentrivana
left a comment
There was a problem hiding this comment.
Thanks for refactoring!
Splitting stuff into more files can be good, but sometimes it creates unnecessary indirection that then leads to more context switching when trying to understand the flow. Same for splitting stuff into functions. Left some comments about that.
Also: I haven't checked the implementation details at all, since as I understand this is just a restructuring with no logic changes, but let me know if that's not the case.
|
Yes, the first 2 PRs are only refactoring. So no logic change. |
Description
Move aws-lambda integraton into package; moved some constants that are now used across modules in
aws_lambda/consts.py.Mainly done for ease of future development and diff-checks