Repository navigation
Prepare manual npm Trusted Publishing with OIDC - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38e096bfcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Checkout release tag | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.tag }} |
There was a problem hiding this comment.
If a branch named v0.3.0 exists, this checkout selects that branch ahead of the identically named tag; it also accepts the branch when no such tag exists. The checkout v4 implementation checks branchExists before tagExists for unqualified refs. If the branch's package version matches, the subsequent version check passes and this workflow publishes branch contents rather than the requested release artifact. Use ref: refs/tags/${{ inputs.tag }} so checkout requires the exact tag and cannot resolve to a branch.
Useful? React with 👍 / 👎.
What changes
id-token: write) instead of permanentNPM_TOKENcredentials.Safety / approval
This PR does not publish anything. Do not run the manual publishing workflow until the npm package's Trusted Publisher has been configured for this exact GitHub repository and
publish.yml, and the maintainer separately approves publishing. For@gitdamnit/stranger-danger(not yet on npm), an initial authenticated bootstrap publication is required before npm will let us establish trust.Review
Confirm workflows pass GitHub YAML/action validation, source tag is the released artifact, and npm ownership / OIDC prerequisites are satisfied before merge.