Repository navigation
Conversation
Forward IgnoreHostsCount and IgnoreHostsThreshold when building static-host probes, matching the other discovery sources. Add focused regression coverage for probe construction and aggregation, including defaults and threshold boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches other discovery sources and is comprehensively tested.
0 open findings
What changed in this PR
Propagates host-ignore settings for static MySQL host discovery.
Changes:
- Copies ignore count and threshold into static-host probes.
- Adds end-to-end coverage for propagation and aggregation behavior.
| File | Description |
|---|---|
pkg/throttle/throttler.go |
Forwards static-host ignore settings. |
pkg/throttle/throttler_test.go |
Tests propagation and aggregation cases. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
IgnoreHostsCountandIgnoreHostsThresholdwhen building static-host probes, matching the other discovery sources.