Repository navigation
fix(app): hide a live window under modals and overlapping menus - #704
Merged
Merged
Conversation
Why: apps/app/src/panels/live.tsx#function isCovered | the native view draws above the page, so anything the page shows over the pane must hide it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live view is a native view drawn above the webview, so it covered Settings and any other modal, plus menus and popovers that reach the pane. The pane now sends an empty box while a dialog backdrop is open or a menu, list or popover overlaps it. That hides the view without stopping capture, and it comes back when the overlay closes.
Checked in a dev build: opening Settings over a live Beats split no longer shows Beats on top, and closing it brings the live view back.
Built in Ace
No. Claude Code in a terminal wrote and checked this, using Desktop Tools to drive the dev build, during a live dogfooding session where the bug was reported from Slack. Ace could have made the change; the outside session was already running the debugging. Tracked under #5.