Repository navigation
feat(app): change text size with Cmd+Plus, Cmd+Minus and Cmd+0, including messages - #709
Merged
Merged
Conversation
…ding messages Why: packages/ui/src/components/scroll-view/scroll-view.tsx#function ScrollView | timeline rows are laid out with fixed-pixel fonts, so text size reaches them only through scale: rows lay out at width / scale under CSS zoom while scroll offsets stay in viewport pixels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idan wanted bigger message text. View now has Bigger Text (Cmd+Plus or Cmd+=), Smaller Text (Cmd+-) and Actual Size (Cmd+0), and the command palette has the same three. The size is saved and shared across windows.
ScrollViewtakes ascale; rows lay out atwidth / scaleand render under CSSzoom, while heights and scroll offsets stay in viewport pixels, so virtualization is unchanged. The timeline reads the scale from the root font size.Checked in a dev build: Cmd+= three times took messages from 16px to 20px with correct rewrapping and no overlapping rows; Cmd+- and Cmd+0 went back down. Known gap: the channels sidebar keeps its pixel width, so at large sizes its contents can clip until it's widened.
Built in Ace
No. Claude Code in a terminal wrote this and drove a dev build with Desktop Tools to check it, in the same session as the dogfooding fixes. Tracked under #5.