Repository navigation
native2: hold input while a caller question is unanswered (#120) - #186
Merged
Merged
Conversation
…eck's perl launcher keeps paths whole (#120) Why: native2/Sources/DesktopHost/Admission.swift | the app's prompt goes up asynchronously, so input right after a caller's refusal must be held by Callers.asking, not only by the on-screen window check Why: scripts/live-check.mjs | one-argument perl system splits on whitespace, so a --server path under Application Support failed to exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found running #120's live checks through the native2 dev app with the user.
Tools.admissiontreated Desktop Tools' own UI as open only once a prompt window was on screen. The app shows its caller prompt asynchronously, so input sent right after an unknown caller's refusal got through before the prompt existed. The live check's desktop_focus completed. Admission now also countsCallers.asking, the callers the app was asked about that the user hasn't answered. Every question ends in a decision, made from the prompt or the menu, andsetDecisionsclears it, so input can't stay held.system, which splits on whitespace. With--serverunderApplication Support, the server failed to exec (exit 255). The block form keeps the path whole.Live, with the user answering:
swift test --filter CoreTestspasses, and the release build has no warnings.