Repository navigation
feat(landing): swipe the screenshot slider on phones - #230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The screenshots slider only answered to the arrows, the thumbnails and the keyboard. On a phone swiping the image, the expected gesture in a carousel, did nothing.
Measured at 360 and 390 px: viewport 312x209 and 342x229, arrows 46x46 sitting on top of the app UI at 30 px from each edge (92 px of 312 covered), two thumbnails of 72x49 that fit the row with no overflow, and no touch handlers in the slider code.
Changes
touch-action: pan-y).prefers-reduced-motion: reduceis set. Inline styles are cleared afterwards so no transform is left behind.aria-live="polite"and the imagedraggable="false". Cache-bust bumped to?v=5.Verification
Playwright suite: 48/48 checks locally and 48/48 against https://nextsync.cloudless.club/.
Already deployed and verified in production.
Closes #229