Repository navigation
fix(landing): drop the PyNextCloud-Sync attribution and the upstream footer link - #242
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The landing still credited PyNextCloud-Sync and its author in the "why it exists" paragraph and linked it as "original project" in the footer. The project no longer presents itself that way, and the paragraph read as a derivation claim rather than a description of NextSync.
Changes
landing/index.html:about.p1rewritten in plain text, no attribution and no anchor, and the footer<li>with the upstream link removed. Cache-busti18n.js?v=10.landing/i18n.js: newabout.p1in ES and EN,footer.upstreamremoved in both dictionaries.Verification
grep -ric "pynextcloud\|ehstbr"onlanding/index.htmlandlanding/i18n.js: 0 matches, andfooter.upstreamno longer exists./tmp/opencode/verify-nxs-about.js: 27/27 at 360, 390 and 1280 px (new text in ES and EN, no anchors in the paragraph, four footer links, no upstream link, no overflow, clean console).Deployed and checked on https://nextsync.cloudless.club/ (0 occurrences in the served HTML and in
i18n.js).Closes #240