Skip to content

Fix WrappedJoin leading blank line for oversized items Copy title #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MateehUllah wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −2
Open

Fix WrappedJoin leading blank line for oversized items Copy title #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3052bf8
fix: avoid leading blank line in WrappedJoin (#705)
MateehUllah Oct 25, 2026
582b1d4
fix: avoid leading blank line in WrappedJoin (#705)
MateehUllah Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fire/formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ def WrappedJoin(items, separator=' | ', width=80):
if len(current_line) + len(item) <= width:
current_line += item
else:
lines.append(current_line.rstrip())
if current_line:
lines.append(current_line.rstrip())
current_line = item
else:
if len(current_line) + len(item) + len(separator) <= width:
current_line += item + separator
else:
lines.append(current_line.rstrip())
if current_line:
lines.append(current_line.rstrip())
current_line = item + separator

lines.append(current_line)
Expand Down
9 changes: 9 additions & 0 deletions fire/formatting_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ def test_wrap_multiple_items(self):
'chicken |',
'cheese'], lines)

def test_wrap_oversized_first_item(self):
self.assertEqual(['long_command'],
formatting.WrappedJoin(['long_command'], width=5))
self.assertEqual(['first |', 'next'],
formatting.WrappedJoin(['first', 'next'], width=5))

def test_wrap_empty_items(self):
self.assertEqual([''], formatting.WrappedJoin([], width=5))

def test_ellipsis_truncate(self):
text = 'This is a string'
truncated_text = formatting.EllipsisTruncate(
Expand Down
Loading