Repository navigation
Fix middle truncation at width boundaries - #724
Open
hugosmoreira wants to merge 1 commit into
Open
hugosmoreira wants to merge 1 commit into
hugosmoreira wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #722.
Keep text unchanged when it exactly fits the available width, and avoid retaining the entire suffix when only the ellipsis fits. Preserve the existing fallback to the full line width when fewer than three characters are available.
Add regression tests in the existing formatting test module for both reported examples, empty/short inputs, odd/even retained ends and fallback boundaries. Five assertions fail before the fix and fail again when the production change is removed.
Validation:
macOS and the remaining hosted version matrix were not run locally.