Repository navigation
Add allow notification option to comment forms - #190
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowNotificationvalue with comment and reply requests instead of always sendingtrue.allowNotificationConfigurable, "允许用户选择是否接收通知") that controls whether the checkbox is available. It is disabled by default; when disabled the checkbox is hidden and notifications are always allowed, preserving the previous behavior.Backend support for respecting this preference is available in Halo 2.27.0 (halo-dev/halo#10313), which this plugin already requires (
>=2.27.0). Only an explicitfalsedisables notifications, so forms that do not set the field keep the previous behavior.Behavior
allowNotification: trueValidation
pnpm -C comment-widget test— 33 files, 181 tests passedpnpm -C comment-widget exec tsc --noEmit— passedpnpm -C comment-widget build— passedbiome checkon the changed files — passed./gradlew compileJava— passedEnd-to-end against a real Halo 2.27.0 instance with this plugin installed:
spec.allowNotificationastrue/falsevia the Halo APIs.someone-replied-to-yousubscriptions only for the allowed cases, and emits no notification reason when replying to a comment whoseallowNotificationisfalse.true; with it on, the checkbox appears checked, and unchecking it sendsfalse.