Repository navigation
fix(ci): stabilize release verification and recheck the deployment commit - #2
Merged
Merged
Conversation
ci: add protected release deployment entry point
shigurenimo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Release verification exposed three test-harness issues: the initialization assertion could start before its synthetic 503 response; unrelated history and member-dialog alerts made a global locator ambiguous; and CMS editing plus the complete link crawl shared one test deadline.
Wait for the synthetic initialization response before asserting the same error, disabled login and recovery. Scope invitation recovery assertions and reload to the member dialog. Split the existing CMS lifecycle and complete navigation crawl into two serial tests, retaining every link, HTTP, guide, permission and lifecycle assertion and the existing per-test timeout. Application behavior is unchanged.
Validation
Formatting, documentation checks and redacted secret scanning passed. Full CI verification is required on this PR and the final release commit. Production deployment remains blocked until the full release checks pass.
Local D1 occasionally reported an internal session-token error; this change does not claim to repair that emulator error.
Publication also rechecks the local HEAD against the SHA captured before verification, so moving a clean release checkout to a different commit cannot reuse the earlier evidence before either upload.
Focused local validation passed all seven initialization/authentication/invitation journeys and both CMS lifecycle/navigation tests.
A subprocess probe simulated HEAD changing between the initial capture and target validation. It stopped with the expected error before any GitHub or Cloudflare operation.