Repository navigation
Align the 2.17 companies endpoints with what the API does - #758
Open
markdennis22 wants to merge 3 commits into
Open
markdennis22 wants to merge 3 commits into
markdennis22 wants to merge 3 commits into
Conversation
Gives company.notes the list shape the API sends, switches the page-number lists to pages_link, splits out the search response, documents the 400s and 503s the API returns, and adds the accepted OAuth scopes to most operations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The create and update company requests reject an array value with a 400, reference attributes included, which is what the scalar-only schema already says. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With `type` set to `user` or `users`, both retrieve-company operations return a paged `user.list` of the company's users instead of the company, so each 200 now lists that shape too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The 2.17 spec for the companies endpoints didn't match the API.
company.noteshad a shape the API never sends, the lists described cursor paging where the API pages by number, and most error responses were missing. Only the 2.17 spec changes, and the SDKs aren't generated from 2.17, so they are unaffected.How?
Corrects the companies endpoints and company schemas to match the API's current behaviour, and adds the OAuth scopes each endpoint accepts to its description.
Generated with Claude Code