Repository navigation
Align the 2.17 and Preview tag, note, segment, subscription type and job endpoints with what the API does - #759
Open
markdennis22 wants to merge 5 commits into
Open
markdennis22 wants to merge 5 commits into
markdennis22 wants to merge 5 commits into
Conversation
…erence with what the API does Declares the query parameters the lists accept, types note ids as strings, switches the note list to pages_link, documents the error responses the API returns, and adds the accepted OAuth scopes to most operations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Any body with a name matches the create-or-update shape, so a request that tags or untags companies or users matched more than one branch and oneOf rejected it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 22, 2026
…view
Applies the same 2.17 changes to the Preview spec, merged operation by operation so Preview-only content stays, such as the `{id}` path parameter name. The next version is cut from Preview, and the Preview SDKs are generated from it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…notes-segments-jobs # Conflicts: # descriptions/0/api.intercom.io.yaml # descriptions/2.17/api.intercom.io.yaml
The missing-body note 400 says "Body can't be nil". The note lists send pages.next as null on the last page and never send prev, and leave author out of list items. include_count adds counts for any value but not a bare key, and company segments only get the count of a contact segment with the same name. Renaming a tag by id to a name over 191 characters, or to one another tag has, returns 200 without saving it. With ids_to_add, users and companies come back empty and a 404 still leaves the tag changed. Preview drops the createNote contact_id body property, which the path value overrides, as 2.17 does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The 2.17 spec for the tag, note, segment, subscription type and job status endpoints didn't match the API. The lists were missing query parameters, note ids were typed as integers, the note list described cursor paging where the API pages by number, and several error responses were missing. The Preview spec had the same problems, and the next version is cut from Preview, so it needs the same fixes.
How?
Corrects these endpoints and their schemas to match the API's current behaviour, and adds the OAuth scopes each endpoint accepts to its description. The same changes go into the Preview spec, keeping content that only applies to Preview, such as the
{id}path parameter name.Risks
The Preview SDKs are generated from this spec, so these changes affect generated Preview types:
ListTagsResponseunion of a tag list or a tag, instead ofTagListGET /tags?id=already returned a single tagidpath parameter on createNote, retrieveNote and deleteNote becomes a stringNoteList.pagesbecomesPagesLinkinstead ofCursorPagespages.nextas an objectSegmentList.pagesgoespagesCreateNoteRequest.contact_idgoesUntagCompanyRequestCompaniesItem.untagbecomes a required booleanuntag, which tags instead of untaggingNotes for reviewers
fern checkshows 0 errors. There are no new dangling refs and no operationId changes, and none of the changed Preview types isunknown.Generated with Claude Code