Repository navigation
Conversation
Correct multidimensional boosting cleanup and purification allocation edge cases, replace the exponent string copy, and expose bounds and flag invariants to static analysis. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a4c53337-212c-416f-87b1-6848855a668b
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 67.30% 67.28% -0.02%
==========================================
Files 77 77
Lines 11739 11739
==========================================
- Hits 7901 7899 -2
- Misses 3838 3840 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove analyzer-only changes and reduce the boosting leak fix to freeing the purification buffer on each early return. Keep the two purification fixes and their regression tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a4c53337-212c-416f-87b1-6848855a668b
paulbkoch
changed the title
Collaborator
Author
|
Closing since I corrected these in main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrowed at the author's request to only three runtime bugs identified while investigating the Windows analysis job:
aWeightson all eight early returns after its allocation in multidimensional boosting. No allocation reordering or cleanup refactor.malloc(0)returns null.The production diff is eight added cleanup calls, a four-line overflow guard, and one changed allocation condition. Two focused purification regression tests are retained. All analyzer-only assertions, pointer initialization, string-copy changes, build warning suppression, and other refactoring have been removed. This PR no longer aims to eliminate every static-analysis warning.
Validation
Rebuilt the final Windows x64 release library and passed all 348 native C API tests, including the two purification regressions. Changed-file formatting and
git diff --checkpass.Local validation used Visual Studio 2026 v145. Local-only
/wd4875and/IGNORE:4315options accommodated existing compiler/linker deprecations; these options are not included in the changes.