Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
01d5d0a
chore(): add updated snapshots
thetaPC Oct 21, 2026
1d3bf59
chore(): add updated snapshots
Ionitron Oct 21, 2026
3882c65
Merge branch 'FW-6838' into FW-6838-snapshots
thetaPC Oct 22, 2026
b75a284
chore(): restore datetime snapshots
thetaPC Oct 22, 2026
ee176f7
Merge branch 'FW-6838' into FW-6838-snapshots
thetaPC Oct 22, 2026
8a8969a
Merge branch 'FW-6838' into FW-6838-snapshots
thetaPC Oct 22, 2026
55b0b5c
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 26, 2026
e57bdff
chore(): add updated snapshots
Ionitron Oct 26, 2026
192d91d
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 26, 2026
43361b6
chore(): add updated snapshots
Ionitron Oct 26, 2026
fdb8a49
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 26, 2026
e24205d
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 27, 2026
ec621b2
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 27, 2026
b556049
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 27, 2026
8fa5083
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 27, 2026
6db8d0b
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 27, 2026
76326d8
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 28, 2026
4ab20bc
chore(): add updated snapshots
Ionitron Oct 28, 2026
8a197d2
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 28, 2026
dec09a0
chore(): add updated snapshots
Ionitron Oct 28, 2026
2602123
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 29, 2026
72ba3bb
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 29, 2026
33e7d63
Merge remote-tracking branch 'origin/FW-6838' into FW-6838-snapshots
thetaPC Oct 29, 2026
da1847c
chore(): add updated snapshots
Ionitron Oct 29, 2026
4e05d23
chore(): add updated snapshots
Ionitron Oct 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ios buttons with an icon and text are still a bit taller than the icon-only ones. Medium is 36px next to 34px and large is 55px next to 50px, while small matches. It's a lot closer than before, but is that expected, or should the icon fit inside the min.height?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made these buttons dark. Expect md solid buttons in an ion-buttons without a toolbar to match the standalone buttons above. Buttons inside a toolbar render the same as before.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Could we add this to BREAKING.md too? Anyone using ion-buttons outside a toolbar in md will see those buttons go from dark to primary, and I didn't see it listed there.

@thetaPC thetaPC Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made these buttons dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made this icon dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made this button dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default ionic toggle is wider than the large one now, 36x48 next to 32x48, where before it was 29x41 and 32x42. I'm guessing that's the leftover padding marked TODO(FW-6846), but could you double check?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of these look like they changed for reasons outside button, like the ios page background here and the ionic-md sheet modal backdrop, and I think a couple of others too. They look right, but it's hard to tell what came from button. Could those be regenerated on ionic-modular first, or called out in the PR body like you did for the toggle?

Loading
Loading