Repository navigation
chore(button): update snapshots for the migration #31630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
01d5d0a
1d3bf59
3882c65
b75a284
ee176f7
8a8969a
55b0b5c
e57bdff
192d91d
43361b6
fdb8a49
e24205d
ec621b2
b556049
8fa5083
6db8d0b
76326d8
4ab20bc
8a197d2
dec09a0
2602123
72ba3bb
33e7d63
da1847c
4e05d23
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The migration moved md's toolbar button styling from
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to me. Could we add this to BREAKING.md too? Anyone using |
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The migration moved md's toolbar button styling from |
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The migration moved md's toolbar button styling from |
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The migration moved md's toolbar button styling from |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default ionic toggle is wider than the large one now, 36x48 next to 32x48, where before it was 29x41 and 32x42. I'm guessing that's the leftover padding marked |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few of these look like they changed for reasons outside button, like the ios page background here and the ionic-md sheet modal backdrop, and I think a couple of others too. They look right, but it's hard to tell what came from button. Could those be regenerated on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ios buttons with an icon and text are still a bit taller than the icon-only ones. Medium is 36px next to 34px and large is 55px next to 50px, while small matches. It's a lot closer than before, but is that expected, or should the icon fit inside the
min.height?