Repository navigation
fix(alert): remove focus outline from wrapper - #31684
Open
ShryukGrandhi wants to merge 1 commit into
Open
ShryukGrandhi wants to merge 1 commit into
ShryukGrandhi wants to merge 1 commit into
Conversation
Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31679
What is the current behavior?
When an alert has inputs or more than one button,
present()moves focus to.alert-wrapper(which hastabindex="0").alert.scssremoves the outline from the host, the buttons and the inputs, but not from the wrapper. On iOS Safari the wrapper matches:focus-visibleafter a tap, so the browser's default focus ring is drawn around the whole dialog.What is the new behavior?
outline: noneon.alert-wrapper, the same way it's already set on the host, buttons and inputs.alert/test/basicthat focuses the wrapper from the keyboard (so it matches:focus-visible) and checks that its computedoutline-styleisnone.Does this introduce a breaking change?
Other information
Before the fix, the new test failed with
outline-styleofauto. After the fix it passes in Mobile Chrome, Mobile Firefox and Mobile Safari (WebKit), for both ios and md modes. The existing focus trap test still passes.Fixes #31679