Repository navigation
fix(select): reject selection while disabled - #31688
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
Reject user selection after the parent becomes disabled while its menu is open. Signed-off-by: Vehbi Karaagac <Xapollon430@gmail.com>
|
@Xapollon430 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31687
What is the current behavior?
If ion-select becomes disabled while its popup is open, the existing options can still change the selection and fire
ionChange. The control should reject user selection once it is disabled.What is the new behavior?
Reject overlay selections when ion-select is disabled. The shared value-commit path covers alert, popover, and action-sheet interfaces.
Does this introduce a breaking change?
Other information
Reproduction
Recorded against @ionic/core 9.0.10. Runnable reproduction includes the required styles and setup.
ionic-disabled-repro.mp4
23 Select spec tests pass, including the new regression; the production build and scoped ESLint pass. All three overlay interfaces were reproduced in Chromium. The new regression fails without the fix.
AI-assisted implementation and testing.