Repository navigation
Conversation
use minecraft's mouse sensitivity to quantize camera rotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Following up on yesterday evening’s discussion, I ran some tests on a private server and found that Controlify’s camera movements did not follow the same rotation steps as vanilla mouse input.
This caused a GCD-based diagnostic to report non-standard rotations while I was simply playing with a controller.
I’ve made a patch that makes controller rotations use the same steps as vanilla mouse input, based on the user's sensitivity setting. It preserves fractional input between frames so small movements aren’t lost.
After this patch server-side checks on the user camera pass. While it's true that it is unlikely as you mentioned that Hypixel checks for these small rotation changes, some servers do, and since adding this patch to the mod made literally zero difference to the gameplay as far as i could tell, I did not bother to add it as a compatibility setting like the WASD movement.
Please let know if there's any change you would like me to make
This aside the mod is wonderful so thank you for the time you took to develop it :)